Skip to content

Compile on BYOND 516.1689 - #589

Merged
Jackriip merged 4 commits into
masterfrom
fix/byond-516-1689
Nov 17, 2026
Merged

Jackriip merged 4 commits into
masterfrom
fix/byond-516-1689

Conversation

@Jackriip

Copy link
Copy Markdown
Member

The game compiles on current BYOND builds again (516.1670 and newer, up to 516.1689) and still compiles on 516.1659, which the server uses.

Newer compilers refuse number keys in list() and the CSS animations in the old chat stylesheet. Both are fixed the way upstream tg fixed them, in tgstation/tgstation#93801 and tgstation/tgstation#95841. One list upstream had already deleted, GLOB.food_quality_events, is converted the same way.

What players notice:

  • The bananium amount on mining corpses and the boneless smite's wound severity now roll with their intended weights. As number-keyed lists they rolled the wrong odds.
  • Hypnosis and phobia text no longer flashes in the old non-tgui chat. tgui chat keeps the effect.
Upstream files touched
  • code/__DEFINES/__globals.dm
  • code/__DEFINES/atmospherics/atmos_piping.dm
  • code/__DEFINES/food.dm
  • code/__DEFINES/research.dm
  • code/controllers/subsystem/dynamic/_dynamic_ruleset.dm
  • code/controllers/subsystem/dynamic/dynamic_ruleset_midround.dm
  • code/controllers/subsystem/dynamic/dynamic_ruleset_roundstart.dm
  • code/controllers/subsystem/processing/station.dm
  • code/controllers/subsystem/timer.dm
  • code/datums/hud.dm
  • code/datums/quirks/neutral_quirks/transhumanist.dm
  • code/game/data_huds.dm
  • code/game/machinery/doors/airlock.dm
  • code/game/machinery/launch_pad.dm
  • code/modules/admin/smites/boneless.dm
  • code/modules/atmospherics/gasmixtures/reactions.dm
  • code/modules/mob/living/basic/bots/_bots.dm
  • code/modules/mob/living/basic/drone/_drone.dm
  • code/modules/mob/living/living.dm
  • code/modules/mob/living/silicon/silicon.dm
  • code/modules/mob/living/simple_animal/bot/bot.dm
  • code/modules/mob_spawn/corpses/mining_corpses.dm
  • code/modules/research/ordnance/_scipaper.dm
  • code/modules/vehicles/mecha/_mecha.dm
  • interface/stylesheet.dm
  • tgui/packages/tgui/interfaces/NtosScipaper.jsx

Not playtested yet.

TealSeer and others added 4 commits November 17, 2026 13:34
BYOND 516.1670 and newer refuse to compile number keys in list().
Lists read by index keep list() with the keys commented out, lists that
need real keys become alists, and the code that read them is updated.
Ported from tgstation/tgstation#93801, minus the mass changeling and
mass traitor rulesets, which this codebase doesn't have.
BYOND 516.1681 validates the CSS in client.script, and DM never
supported the animation rules on .hypnophrase and .phobia, so newer
compilers fail on them. tgui chat keeps its own copies of these styles.
Ported from tgstation/tgstation#95841.
Upstream deleted this list before its alist rewrite, so the port missed
it. It is only read by index.
@Jackriip
Jackriip merged commit 992c878 into master Nov 17, 2026
5 checks passed
@Jackriip
Jackriip deleted the fix/byond-516-1689 branch November 17, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants