Repository navigation
Compile on BYOND 516.1689 - #589
Merged
Merged
Conversation
BYOND 516.1670 and newer refuse to compile number keys in list(). Lists read by index keep list() with the keys commented out, lists that need real keys become alists, and the code that read them is updated. Ported from tgstation/tgstation#93801, minus the mass changeling and mass traitor rulesets, which this codebase doesn't have.
BYOND 516.1681 validates the CSS in client.script, and DM never supported the animation rules on .hypnophrase and .phobia, so newer compilers fail on them. tgui chat keeps its own copies of these styles. Ported from tgstation/tgstation#95841.
Upstream deleted this list before its alist rewrite, so the port missed it. It is only read by index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game compiles on current BYOND builds again (516.1670 and newer, up to 516.1689) and still compiles on 516.1659, which the server uses.
Newer compilers refuse number keys in
list()and the CSS animations in the old chat stylesheet. Both are fixed the way upstream tg fixed them, in tgstation/tgstation#93801 and tgstation/tgstation#95841. One list upstream had already deleted,GLOB.food_quality_events, is converted the same way.What players notice:
Upstream files touched
code/__DEFINES/__globals.dmcode/__DEFINES/atmospherics/atmos_piping.dmcode/__DEFINES/food.dmcode/__DEFINES/research.dmcode/controllers/subsystem/dynamic/_dynamic_ruleset.dmcode/controllers/subsystem/dynamic/dynamic_ruleset_midround.dmcode/controllers/subsystem/dynamic/dynamic_ruleset_roundstart.dmcode/controllers/subsystem/processing/station.dmcode/controllers/subsystem/timer.dmcode/datums/hud.dmcode/datums/quirks/neutral_quirks/transhumanist.dmcode/game/data_huds.dmcode/game/machinery/doors/airlock.dmcode/game/machinery/launch_pad.dmcode/modules/admin/smites/boneless.dmcode/modules/atmospherics/gasmixtures/reactions.dmcode/modules/mob/living/basic/bots/_bots.dmcode/modules/mob/living/basic/drone/_drone.dmcode/modules/mob/living/living.dmcode/modules/mob/living/silicon/silicon.dmcode/modules/mob/living/simple_animal/bot/bot.dmcode/modules/mob_spawn/corpses/mining_corpses.dmcode/modules/research/ordnance/_scipaper.dmcode/modules/vehicles/mecha/_mecha.dminterface/stylesheet.dmtgui/packages/tgui/interfaces/NtosScipaper.jsxNot playtested yet.